Skip to content

Add basic success case unit tests of the shared code dealing with peers. #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 3, 2025
Merged

Add basic success case unit tests of the shared code dealing with peers. #324

merged 1 commit into from
Sep 3, 2025

Conversation

albu-diku
Copy link
Contributor

No description provided.

@albu-diku albu-diku force-pushed the test/cover-accountreq-peers branch from 8a54943 to 8785959 Compare September 1, 2025 15:54
jonasbardino
jonasbardino reviewed Sep 1, 2025
View reviewed changes
jonasbardino
jonasbardino reviewed Sep 1, 2025
View reviewed changes
jonasbardino
jonasbardino reviewed Sep 1, 2025
View reviewed changes
Copy link
Contributor

@jonasbardino jonasbardino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good. Please address the minor comments and add at least the missing class docstring in the new accountreq unit test. Those longer private methods could probably also use a line of doc.

@jonasbardino jonasbardino mentioned this pull request Sep 1, 2025
Merged
@albu-diku albu-diku force-pushed the test/cover-accountreq-peers branch from 8785959 to 5770dbb Compare September 2, 2025 14:11
jonasbardino
jonasbardino reviewed Sep 3, 2025
View reviewed changes
jonasbardino
jonasbardino reviewed Sep 3, 2025
View reviewed changes
jonasbardino
jonasbardino reviewed Sep 3, 2025
View reviewed changes
Copy link
Contributor

@jonasbardino jonasbardino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting closer with just one or two bits left :)

@jonasbardino jonasbardino added the test-only Improvements or additions solely for better test coverage - without functionality changes label Sep 3, 2025
@jonasbardino jonasbardino self-assigned this Sep 3, 2025
@albu-diku albu-diku force-pushed the test/cover-accountreq-peers branch from 5770dbb to b4987d7 Compare September 3, 2025 16:00
@jonasbardino jonasbardino merged commit 3d33d65 into next Sep 3, 2025
10 checks passed
@jonasbardino jonasbardino deleted the test/cover-accountreq-peers branch September 3, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonasbardino jonasbardino jonasbardino left review comments

Assignees

@jonasbardino jonasbardino

Labels
test-only Improvements or additions solely for better test coverage - without functionality changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@albu-diku @jonasbardino